Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

updater: apply exponential backoff after download failure #8059

Merged
merged 2 commits into from
Mar 6, 2018

Conversation

andresilva
Copy link
Contributor

@andresilva andresilva commented Mar 5, 2018

Part of #7272.

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. B0-patch M4-core ⛓ Core client code / Rust. labels Mar 5, 2018
@5chdn 5chdn added this to the 1.11 milestone Mar 5, 2018
Copy link
Collaborator

@kirushik kirushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for this behavior?
Do we even have tests for the updater anywhere? It seems rather important part of our codebase.

@andresilva
Copy link
Contributor Author

No, we don't have any tests for the updater (or at least not any meaningful ones) and I don't think it is very testable right now. I want to refactor it as part of #7272.

Copy link
Collaborator

@kirushik kirushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's merge it "as is" and then cover it with tests as a part of #7272

@kirushik kirushik added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 5, 2018
@debris debris merged commit f48b09b into master Mar 6, 2018
@debris debris deleted the andre-updater-backoff branch March 6, 2018 20:16
tomusdrw pushed a commit that referenced this pull request Mar 16, 2018
* updater: apply exponential backoff after download failure

* updater: reset backoff on new release
@tomusdrw tomusdrw mentioned this pull request Mar 16, 2018
9 tasks
andresilva added a commit that referenced this pull request Mar 16, 2018
* updater: apply exponential backoff after download failure

* updater: reset backoff on new release
@andresilva andresilva mentioned this pull request Mar 16, 2018
14 tasks
debris pushed a commit that referenced this pull request Mar 19, 2018
* updater: apply exponential backoff after download failure (#8059)

* updater: apply exponential backoff after download failure

* updater: reset backoff on new release

* Limit incoming connections.  (#8060)

* Limit ingress connections
* Optimized handshakes logging

* Max code size on Kovan (#8067)

* Enable code size limit on kovan

* Fix formatting.

* add some dos protection (#8084)

* more dos protection (#8104)

* Const time comparison (#8113)

* Use `subtle::slices_equal` for constant time comparison.

Also update the existing version of subtle in `ethcrypto` from
0.1 to 0.5

* Test specifically for InvalidPassword error.

* revert removing blooms (#8066)

* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs

* Fix compilation.

* Check one step deeper if we're on release track branches

* add missing pr

* Fix blooms?

* Fix tests compiilation.

* Fix size.
andresilva added a commit that referenced this pull request Mar 19, 2018
* updater: apply exponential backoff after download failure

* updater: reset backoff on new release
tomusdrw pushed a commit that referenced this pull request Mar 19, 2018
* Support parity protocol. (#8035)

* updater: apply exponential backoff after download failure (#8059)

* updater: apply exponential backoff after download failure

* updater: reset backoff on new release

* Max code size on Kovan (#8067)

* Enable code size limit on kovan

* Fix formatting.

* Limit incoming connections.  (#8060)

* Limit ingress connections
* Optimized handshakes logging

* WASM libraries bump (#7970)

* update wasmi, parity-wasm, wasm-utils to latest version

* Update to new wasmi & error handling

* also utilize new stack limiter

* fix typo

* replace dependency url

* Cargo.lock update

* add some dos protection (#8084)

* revert removing blooms (#8066)

* Revert "fix traces, removed bloomchain crate, closes #7228, closes #7167"

This reverts commit 1bf6203.

* Revert "fixed broken logs (#7934)"

This reverts commit f8a2e53.

* fixed broken logs

* bring back old lock order

* remove migration v13

* revert CURRENT_VERSION to 12 in migration.rs

* more dos protection (#8104)

* Const time comparison (#8113)

* Use `subtle::slices_equal` for constant time comparison.

Also update the existing version of subtle in `ethcrypto` from
0.1 to 0.5

* Test specifically for InvalidPassword error.

* fix trace filter returning returning unrelated reward calls, closes #8070 (#8098)

* network: init discovery using healthy nodes (#8061)

* network: init discovery using healthy nodes

* network: fix style grumble

* network: fix typo

* Postpone Kovan hard fork (#8137)

* ethcore: postpone Kovan hard fork

* util: update version fork metadata

* Disable UI by default. (#8105)

* dapps: update parity-ui dependencies (#8160)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants